fix(compat): an absolute DT_NEEDED is not a soname, and a missing tool is not an empty answer - #382
Merged
Conversation
…l is not an empty answer
Two defects that only appear when `compat.glx-runtime`'s new pass is actually
executed. The previous change measured the opencl and vulkan farms; the glx one
had never been run.
AN ABSOLUTE `DT_NEEDED` NEVER GOES THROUGH A SEARCH PATH. Four members of this
farm -- the glvnd vendor entries `libEGL_nvidia`, `libGLESv1_CM_nvidia`,
`libGLESv2_nvidia` and `libGLX_nvidia` -- name `/lib/x86_64-linux-gnu/...`
outright. The loader opens those directly, so the farm can neither serve them
nor honestly record them as unserved. Treating one as a soname looks up a name
with slashes in it and then writes an `unserved` link whose NAME is a path. All
three recipes skip them.
A MISSING TOOL IS NOT AN EMPTY ANSWER. With `readelf` absent the pass returned
`{}`, which reads exactly like a farm with no gaps -- the confusion this whole
batch exists to remove, one layer down in the tool lookup. It now warns, and
`compat.glx-runtime`'s lookup reaches the xim store before PATH like the other
two, because this package runs on machines that were never asked to have a
toolchain.
Measured against the installed glx farm with the same logic: 52 members, 4
absolute entries skipped, 19 sonames needed, all 19 filled from ecosystem
payloads, 0 unserved, and no path-shaped entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two defects that only appear when
compat.glx-runtime's new pass is actually executed. #380 measured the opencl and vulkan farms; the glx one had never been run.An absolute
DT_NEEDEDnever goes through a search pathFour members of this farm — the glvnd vendor entries
libEGL_nvidia,libGLESv1_CM_nvidia,libGLESv2_nvidia,libGLX_nvidia— name/lib/x86_64-linux-gnu/...outright:The loader opens those directly. The farm can neither serve them nor honestly record them as unserved — and treating one as a soname looks up a name with slashes in it, then writes an
unservedlink whose name is a path. All three recipes now skip them.A missing tool is not an empty answer
With
readelfabsent the pass returned{}— which reads exactly like "this farm has no gaps". That is the confusion this whole batch exists to remove, one layer down, in the tool lookup. It now warns, andcompat.glx-runtime's lookup reaches the xim store before PATH like the other two, because this package runs on machines that were never asked to have a toolchain.Measured
Against the installed glx farm, running the same logic:
Four come from
xim:nvidia-gl-host-link, the rest from the stackxim:graphicspulls in.